Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat/update dot com domain #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Conversation

dwightgunning
Copy link
Contributor

This is a sanitised version of the feat/update-dot-com-domain branch.

Also tidies up travis config.
@dwightgunning dwightgunning self-assigned this Oct 16, 2017
@JelteF
Copy link
Contributor

JelteF commented Oct 16, 2017

LGTM, but the last commit message is very confusing. Because below 2.7.9 doesn't fall back to getstream.io, it als uses the .com domain but it connects using the OpenSSL libs.

@JelteF
Copy link
Contributor

JelteF commented Oct 16, 2017

All tests passing indicates that stuff is still working with the new domain BTW.

Updated tests and added extra heroku compatibility tests
@dwightgunning
Copy link
Contributor Author

Yeah that is lame @JelteF - I'll reword the commit message.

@dwightgunning dwightgunning force-pushed the feat/update-dot-com-domain-2 branch from 1209cfa to 55deb5b Compare October 17, 2017 09:12
@dwightgunning dwightgunning merged commit 2a9c896 into master Oct 17, 2017
@dwightgunning dwightgunning deleted the feat/update-dot-com-domain-2 branch April 30, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants