Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add pre-push spotless check to prevent pushes if spotlessApply has not been run #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Dec 18, 2023
Merged

Add pre-push spotless check to prevent pushes if spotlessApply has not been run #964

merged 42 commits into from
Dec 18, 2023

Conversation

aleksandar-apostolov
Copy link
Contributor

No description provided.

@aleksandar-apostolov
User service compat to start the ongoing call service providing the s…
a73d01d 
…ervice type
@aleksandar-apostolov
Call service to manage the call from foreground service
c79c715
@aleksandar-apostolov
Route incoming call via the CallService along with the notification d…
3aadfbd 
…isplay.
@aleksandar-apostolov
Update API
bab1fd2
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
1ff248c
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
2f847e9
@aleksandar-apostolov
Remove call#get, state is already updated in service
09bb9af
@aleksandar-apostolov
On the caller side, use #reject() instead of #leave() to indicate whe…
38880c4 
…n a call is canceled
@aleksandar-apostolov
Subscribe for call events and stop service on call#reject or call#ended
bcf9416
@aleksandar-apostolov
Spotless
605c77b
@aleksandar-apostolov
Add supervisor job to service
a59f915
@aleksandar-apostolov
Remove redundant call checks from IncomingCallActivity
a4dc4f0
@aleksandar-apostolov
Spotless, reject call when caller closes activity, reject call instea…
7623d1a 
…d of leave in incoming call activity
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
c13254b
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
1320528
@aleksandar-apostolov
Update optional call to lateinit call
b312a69
@aleksandar-apostolov
Revert back IncomingCalLActivity changes
ad9b390
@aleksandar-apostolov
Spotless
4bec184
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
fd6acd2
@aleksandar-apostolov
Handle ringing state in the service and correctly connect the socket
f6b638f
@aleksandar-apostolov
Use service scope instead of individual jobs, also cancel the incomin…
534ade9 
…g call notification when destroying the service
@aleksandar-apostolov
Apply spotless
61048cb
@aleksandar-apostolov
Update API
70ef992
@aleksandar-apostolov
Merge branch 'develop' into incomming_calls_handling
5df855f 
# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/OngoingCallService.kt
@aleksandar-apostolov
Merge call handling when UI is destroyed
f019910
@aleksandar-apostolov
Apply spotless
9d56d2f
@aleksandar-apostolov
Finish the caller Activity if there is a call.reject
b805267
@aleksandar-apostolov
Apply spotless
9f7d4c7
@aleksandar-apostolov
Add pre-commit hook for spotless
383c427
@aleksandar-apostolov
Test pre-commit hook
c3a0763
@liviu-timar
Copy link
Contributor

This would be great 😄

@aleksandar-apostolov aleksandar-apostolov changed the title Test PR to check if possible to add pre-commit hook for spotless Add pre-push spotless check to prevent pushes if spotlessApply has not been run Dec 14, 2023
@aleksandar-apostolov aleksandar-apostolov marked this pull request as ready for review December 15, 2023 13:20
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner December 15, 2023 13:20
skydoves
skydoves approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

@aleksandar-apostolov aleksandar-apostolov merged commit 9532505 into develop Dec 18, 2023
@aleksandar-apostolov aleksandar-apostolov deleted the pre_commit_spotless branch December 18, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skydoves skydoves skydoves approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandar-apostolov @liviu-timar @skydoves