Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat/add pagination #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 24, 2023
Merged

Feat/add pagination #66

merged 19 commits into from
Dec 24, 2023

Conversation

Brownjy
Copy link
Collaborator

@Brownjy Brownjy commented Dec 21, 2023 •
edited
Loading

  • repo list pagination
  • branch list pagination

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d23fa78) 62.35% compared to head (68e76e4) 62.98%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   62.35%   62.98%   +0.62%     
==========================================
  Files         100      101       +1     
  Lines       10045    10186     +141     
==========================================
+ Hits         6264     6416     +152     
+ Misses       3149     3139      -10     
+ Partials      632      631       -1
Files Coverage Δ
controller/branch_ctl.go 83.25% <100.00%> (+2.07%) ⬆️
models/branch.go 92.17% <100.00%> (+4.93%) ⬆️
models/repository.go 87.02% <100.00%> (+3.15%) ⬆️
utils/pagination.go 100.00% <100.00%> (ø)
controller/repository_ctl.go 84.79% <96.10%> (+2.74%) ⬆️

... and 1 file with indirect coverage changes

hunjixin
hunjixin reviewed Dec 21, 2023
View reviewed changes
hunjixin
hunjixin reviewed Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 但是还有点小改动需要处理。

@Brownjy Brownjy requested a review from hunjixin December 22, 2023 09:36
hunjixin
hunjixin approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Brownjy and others added 3 commits December 25, 2023 00:30
@Brownjy
Merge branch 'main' into feat/add_pagination
f493165 
# Conflicts:
#	api/jiaozifs.gen.go
#	controller/branch_ctl.go
#	integrationtest/branch_test.go
#	models/branch_test.go
@Brownjy
chore: rebuild import by goimports
81bc5fe
@Brownjy
chore: make gen api
68e76e4
@Brownjy Brownjy merged commit d4fb5c5 into main Dec 24, 2023
@Brownjy Brownjy deleted the feat/add_pagination branch December 24, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunjixin hunjixin hunjixin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brownjy @hunjixin