Map null in map to undefined for JS database #493
Conversation
|
@nbransby re #448 (comment) Im not sure how JS is supposed to handle null in a map though. Like in |
|
I should note that if I go back to the commit before the Serialization changes where merged, I dont see anything that would do this mapping either. |
|
Yes I had a look myself and couldn't see anything either. All I know is rolling back fixes it, I'll have to investigate it more |
|
Lets see if we can write a test that reproduces it I guess |
|
So far, on master. I havent been able to reproduce using: @Test
fun testUpdateChildren() = runTest {
setupRealtimeData()
val reference = database
.reference("FirebaseRealtimeDatabaseTest")
reference.updateChildren(mapOf("lastActivity" to null))
}
private suspend fun setupRealtimeData() {
ensureDatabaseConnected()
val firebaseDatabaseTestReference = database
.reference("FirebaseRealtimeDatabaseTest")
val firebaseDatabaseChildTest1 = FirebaseDatabaseChildTest("aaa")
val firebaseDatabaseChildTest2 = FirebaseDatabaseChildTest("bbb")
val firebaseDatabaseChildTest3 = FirebaseDatabaseChildTest("ccc")
val values = firebaseDatabaseTestReference.child("values")
values.child("1").setValue(firebaseDatabaseChildTest1)
values.child("2").setValue(firebaseDatabaseChildTest2)
values.child("3").setValue(firebaseDatabaseChildTest3)
firebaseDatabaseTestReference.child("lastActivity").setValue(1)
}given Whereas |
|
I found a bug in OnDisconnect specifically, will make a patch for that once I have testing figured out |
|
Closing cause real fix is here #494 |
No description provided.