Added separate job for apiCheck #753
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a separate job for running API checks in the GitHub Actions workflows. The change separates API validation from the main linting job to improve workflow organization and potentially allow for parallel execution.
- Extracted API check functionality into a dedicated job in the pull request workflow
- Added API dump and check steps to the push workflow for maintaining API files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/push.yml | Added API dump step and API check step, improved step naming |
| .github/workflows/pull_request.yml | Extracted API check into separate job with its own environment setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| distribution: 'zulu' | ||
| java-version: '17' | ||
| - name: Run Api Check | ||
| run: ./gradlew apiCheck |
There was a problem hiding this comment.
Inconsistent indentation: this step uses 5 spaces while other steps in the workflow use 8 spaces. The indentation should be consistent with the existing workflow format.
| run: ./gradlew apiCheck | |
| - uses: actions/checkout@v4 | |
| - name: Set up JDK | |
| uses: actions/setup-java@v4 | |
| with: | |
| distribution: 'zulu' | |
| java-version: '17' | |
| - name: Run Api Check | |
| run: ./gradlew apiCheck |
| distribution: 'zulu' | ||
| java-version: '17' | ||
| - name: Run Api Check | ||
| run: ./gradlew apiCheck |
There was a problem hiding this comment.
Inconsistent indentation: this step uses 5 spaces while other steps in the workflow use 8 spaces. The indentation should be consistent with the existing workflow format.
| run: ./gradlew apiCheck | |
| - uses: actions/checkout@v4 | |
| - name: Set up JDK | |
| uses: actions/setup-java@v4 | |
| with: | |
| distribution: 'zulu' | |
| java-version: '17' | |
| - name: Run Api Check | |
| run: ./gradlew apiCheck |
| distribution: 'zulu' | ||
| java-version: '17' | ||
| - name: Run Api Check | ||
| run: ./gradlew apiCheck |
There was a problem hiding this comment.
Inconsistent indentation: this step uses 5 spaces while other steps in the workflow use 8 spaces. The indentation should be consistent with the existing workflow format.
| run: ./gradlew apiCheck | |
| - uses: actions/checkout@v4 | |
| - name: Set up JDK | |
| uses: actions/setup-java@v4 | |
| with: | |
| distribution: 'zulu' | |
| java-version: '17' | |
| - name: Run Api Check | |
| run: ./gradlew apiCheck |
No description provided.