Make GitFlowVersion tests play nice when being run by a TeamCity agent #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreasohlund It looks like there are no agents available to build this one. Could you please take a look? |
|
They just take a while to spin up (aws dynamic instances). Sent from my iPhone
|
|
This PR now makes TeamCity happy.
I'm no quite sure to understand why did |
andreasohlund
added a commit
that referenced
this pull request
Nov 27, 2013
Make GitFlowVersion tests play nice when being run by a TeamCity agent
nulltoken
referenced
this pull request
in JakeGinnivan/GitHubFlowVersion
Dec 14, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32 introduced some test coverage in order to ensure that GFV was behaving as expected when being leveraged in a build tool chain on a TeamCity agent.
The way GFV detects this context is by probing the existence of a
TEAMCITY_VERSIONenvironment variable.However, when those tests actually ran on a TeamCity agent, this very variable was always set which led to some failures.
This PR introduces a switch regarding the probing mechanism.
TEAMCITY_VERSIONwill be used when GFV is being run as a MSBuild taskGitFlowVersion.Fake.TEAMCITY_VERSIONwill be used when testing GFV