Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Relaxed tagging and more #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 10, 2013
Merged

Relaxed tagging and more #51

merged 8 commits into from
Dec 10, 2013

Conversation

nulltoken
Copy link
Contributor

  • Ensure a release branch branch off develop
  • Relax the requirement to tag hotfix branches
  • Relax the requirement to tag release branches
  • Review

Fix #25
Fix #33

@nulltoken
Copy link
Contributor Author

This build failed. However it looks like the errors are unrelated to this PR

/cc @SimonCropp

using System.Linq;
using LibGit2Sharp;

internal abstract class CommitBasedVersionFinderBase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal is redundant

@nulltoken
Copy link
Contributor Author

@andreasohlund Thanks a lot for all those comments!

Below a new proposal.

Considering the following repo

               H1    H2     H3     H4   H5
          /----|-----|------|------|----|-----hotfix-1.0.1
         /
---|----|-------------------------------------master
   A    B

With the following decorations:

  • A bears a tag "1.0.1-alpha1"
  • H1 bears no tag
  • H2 bears a "1.0.1-alpha2" tag
  • H3 bears a "1.0.1-rc4" tag and a more recent "1.0.1-beta1" tag
  • H4 bears a "1.0.2-alpha1" tag
  • H5 bears a "andreas" tag

The process will search for a potential tag in the scope [B, H5]. The most recent tag matching the version of the branch will be used.

As such

  • H5 tag will be ignored (not a version)
  • H4 tag will be ignored (non matching version). Or should we throw here?
  • Both H3 tag will be considered. The most recent one will be used (ie. the "beta1")
  • H2 will not be tested as a valid tag as been found above
  • B will not be tested as a valid tag as been found above
  • A will never be be considered as it's a ancestor of the branching commit.

Moreover, regarding the branch naming convention, I propose the ensure the following policy

  • A release or hotfix branch should never bear a stability/prerelease part

How does that sound?

@andreasohlund
Copy link
Contributor

All seems valid, go ahead!

Sent from my iPhone

On 7 dec 2013, at 17:07, nulltoken [email protected] wrote:

@andreasohlund Thanks a lot for all those comments!

Below a new proposal.

Considering the following repo

           H1    H2     H3     H4   H5
      /----|-----|------|------|----|-----hotfix-1.0.1
     /

---|----|-------------------------------------master
A B
With the following decorations:

A bears a tag "1.0.1-alpha1"
H1 bears no tag
H2 bears a "1.0.1-alpha2" tag
H3 bears a "1.0.1-rc4" tag and a more recent "1.0.1-beta1" tag
H4 bears a "1.0.2-alpha1" tag
H5 bears a "andreas" tag
The process will search for a potential tag in the scope [B, H5]. The most recent tag matching the version of the branch will be used.

As such

H5 tag will be ignored (not a version)
H4 tag will be ignored (non matching version). Or should we throw here?
Both H3 tag will be considered. The most recent one will be used (ie. the "beta1")
H2 will not be tested as a valid tag as been found above
B will not be tested as a valid tag as been found above
A will never be be considered as it's a ancestor of the branching commit.
Moreover, regarding the branch naming convention, I propose the ensure the following policy

A release or hotfix branch should never bear a stability/prerelease part
How does that sound?


Reply to this email directly or view it on GitHub.

@SimonCropp
Copy link
Contributor

@nulltoken fixed the tests

@nulltoken
Copy link
Contributor Author

Fixed and rebased.

SimonCropp added a commit that referenced this pull request Dec 10, 2013
@SimonCropp SimonCropp merged commit da2b117 into master Dec 10, 2013
@nulltoken nulltoken deleted the ntk/topic/relaxed_tagging branch December 10, 2013 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax the requirement to tag release + hotfix branches right away Validate that branch names follow GitFlow
3 participants