-
Notifications
You must be signed in to change notification settings - Fork 654
Relaxed tagging and more #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This build failed. However it looks like the errors are unrelated to this PR /cc @SimonCropp |
using System.Linq; | ||
using LibGit2Sharp; | ||
|
||
internal abstract class CommitBasedVersionFinderBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal is redundant
@andreasohlund Thanks a lot for all those comments! Below a new proposal. Considering the following repo
With the following decorations:
The process will search for a potential tag in the scope [B, H5]. The most recent tag matching the version of the branch will be used. As such
Moreover, regarding the branch naming convention, I propose the ensure the following policy
How does that sound? |
All seems valid, go ahead! Sent from my iPhone
|
@nulltoken fixed the tests |
Fixed and rebased. |
Fix #25
Fix #33