Work around nextest macro lib compatibility bug#1372
Merged
Conversation
This sets the `RUSTUP_WINDOWS_PATH_ADD_BIN` environment variable in the multi-platform test job, to work around nextest-rs/nextest#1493 which is keeping the test runner from working on Windows. See also ruffle-rs/ruffle#16342, which gave the idea for this, and various other projects that have made such changes, linked in nextest-rs/nextest#1493.
95f057f to
c099b54
Compare
Sebastian Thiel (Byron)
approved these changes
May 17, 2024
Member
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a million!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the
RUSTUP_WINDOWS_PATH_ADD_BINenvironment variable in the multi-platform test job, to work around nextest-rs/nextest#1493 which is keeping the test runner from working on Windows. See also ruffle-rs/ruffle#16342, which gave the idea for this, and various other projects that have made such changes, linked in nextest-rs/nextest#1493.Running
cargo nextest run --allon Windows produces output like:I believe the relevant portion of the output starts at
error: creating test list failed. Attempting to run the command manually shows:As mentioned in #1371 (comment), this occurs both locally and on CI and is not specific to changes proposed in #1371, nor is it related to
gix-macroschanges in bad5b48 (#1363).I've gone ahead and set that environment variable for all three platforms that have
test-fastCI jobs, but not in other jobs. It does not appear to cause problems for other platforms. Once this change is no longer needed, it should probably be reverted, but I think it is useful right now because it should let #1371 and any other forthcoming PRs move forward.