Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix using trait object DynNestedProgress#24

Merged
Sebastian Thiel (Byron) merged 2 commits into
GitoxideLabs:mainfrom
NobodyXu:fix/dyn
Sep 9, 2023
Merged

Fix using trait object DynNestedProgress#24
Sebastian Thiel (Byron) merged 2 commits into
GitoxideLabs:mainfrom
NobodyXu:fix/dyn

Conversation

@NobodyXu
Copy link
Copy Markdown
Contributor

No description provided.

Relaxed `Count` and `Progress` for references for unsized types.

Signed-off-by: Jiahao XU <[email protected]>
@Byron
Copy link
Copy Markdown
Member

Is there any compatibility issue when doing this? I think the question really is: Why would one ever not want to use ?Sized? I vaguely remember Clone to not use ?Sized for example, but maybe it's not object safe anyway. Confused already 😅.

@NobodyXu
Copy link
Copy Markdown
Contributor Author

My opinion on this is that unless you encounters a conflict implementation or you need to take self by value, otherwise there's no reason not to add ?Sized bound.

@Byron Sebastian Thiel (Byron) merged commit c905d5c into GitoxideLabs:main Sep 9, 2023
@Byron
Copy link
Copy Markdown
Member

A new release is now available: https://github.com/Byron/prodash/releases/tag/v26.2.2 .

@NobodyXu Jiahao XU (NobodyXu) deleted the fix/dyn branch September 9, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants