fix bugs with DevAppServer and EE8 #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…t with DevAppServer Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
|
We will need a regression test both for EE 8 and EE 10. |
|
Also for the record, the regression was introduced in https://github.com/GoogleCloudPlatform/appengine-java-standard/pull/105/files |
ludoch
approved these changes
May 14, 2024
|
We will wait for the regression test, approving only for nighty build |
Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
May 14, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 633438786 Change-Id: I8e9d23b47737d144580b520e315e7b7230f7f728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalResourceFileServlet.startWebApp()method introduced in 12.0.8 for EE8AppEngineWebAppContext.NullPointerExceptioncaused because theHtmlEscaperrejects null value for the error message from theResponseRewriteFilter.ResponseRewriterFilter.ResponseWrapperwas committing the response twice.