Initialize HttpChannel in DelegateConnection to create Violation Listeners #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eners. Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
Aug 20, 2024
|
related to internal bug 359557991 |
|
Probeapp.java running for java21 should have detected it, but our internal prober has an issue unrelated for that. |
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 665152522 Change-Id: Ic400711139f630bbc28342daec4b1871edbefa2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DelegateConnectionis missing a call to initialize theHttpChannelthis is necessary to create the violation listeners.Currently violations reported will cause NPE as the listener has not been set.