allow Jetty 9.4 jetty-servlets class names to work with Jetty 12 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
|
Note some of the classes in
|
maigovannon
reviewed
Feb 19, 2025
...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/ee10/AppEngineWebAppContext.java
Outdated
Show resolved
Hide resolved
...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/ee10/AppEngineWebAppContext.java
Outdated
Show resolved
Hide resolved
|
@maigovannon Ideally, a member in BLR should add a e2e test for such app using these servlets. Good learning step in our e2e app tests in this repo. |
|
Also wondering if the local devappserver would also serve such apps... |
Makes sense. We can take it up as a follow-up. |
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
maigovannon
approved these changes
Feb 20, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
…is related to #345 PiperOrigin-RevId: 735623640 Change-Id: I6b2e351765d0778cc2ded07255be8c84b46181db
ludoch
added a commit
that referenced
this pull request
Mar 18, 2025
* Bump io.netty:netty-common from 4.1.117.Final to 4.1.118.Final Bumps [io.netty:netty-common](https://github.com/netty/netty) from 4.1.117.Final to 4.1.118.Final. - [Commits](netty/netty@netty-4.1.117.Final...netty-4.1.118.Final) --- updated-dependencies: - dependency-name: io.netty:netty-common dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * - Add Maven CI action for building with Zulu and Liberica JDKs for Java 21, 23. - Removing Java 22 from all JDK since we can now safely just test on JDK23 and the upcoming JDK24. PiperOrigin-RevId: 727603486 Change-Id: I73c659ef58fe85fb6d9964d0997949eccec08aeb * allow Jetty 9.4 jetty-servlets class names to work with Jetty 12 Signed-off-by: Lachlan Roberts <[email protected]> * allow Jetty 9.4 jetty-servlets class names to work with Jetty 12 Signed-off-by: Lachlan Roberts <[email protected]> * allow Jetty 9.4 jetty-servlets class names to work with Jetty 12 Signed-off-by: Lachlan Roberts <[email protected]> * Upgrade GAE Java version from 2.0.32 to 2.0.33 and prepare next version 2.0.34-SNAPSHOT PiperOrigin-RevId: 728533780 Change-Id: Ic8bd0b0863999092f469267dbb15d0eca39a92db * PR #345 - changes from review Signed-off-by: Lachlan Roberts <[email protected]> * PR #345 - fixes for broken tests Signed-off-by: Lachlan Roberts <[email protected]> * Set API host idle timeout to 2 seconds by default instead of no timeout. See jetty/jetty.project#3891 PiperOrigin-RevId: 729286826 Change-Id: Iea5120e9e46db5874fd95426537f4136bf876f84 * Set API host idle timeout to 2 seconds by default instead of no timeout. See jetty/jetty.project#3891 PiperOrigin-RevId: 729581319 Change-Id: I85a21e3fdd2cc5c5c250ff048632f5687870a049 * Update all non-major dependencies * Set API host idle timeout to 25 seconds by default instead of no timeout. See jetty/jetty.project#3891 PiperOrigin-RevId: 731360214 Change-Id: Ifedd44381e45a318ab38705d910ba3f41317ee79 * Update all non-major dependencies * Update to Jetty 12.0.17 and allow invalid pathSpecs in EE8 Signed-off-by: Lachlan Roberts <[email protected]> * Internal change PiperOrigin-RevId: 734104453 Change-Id: I0ad3f52c675374e3f9337a02ebf5b5668eef8b1b * Update all non-major dependencies * Adding `org.eclipse.jetty.servlet` to deprecated package names. This is related to #345 PiperOrigin-RevId: 735623640 Change-Id: I6b2e351765d0778cc2ded07255be8c84b46181db * Fix App Engine tests for Windows. This change addresses several issues that prevented App Engine tests from passing on Windows: - **Maven Wrapper:** The Maven wrapper executable `mvnw` is now invoked with the `.cmd` extension when running on Windows to ensure it can be executed correctly. - **Newline Handling:** Test output reading logic has been updated to handle both `\n` and `\r\n` newline representations, which is necessary for Windows compatibility. These changes ensure that the affected tests pass on both Linux/macOS and Windows environments. PiperOrigin-RevId: 736207509 Change-Id: I7c11b010689343ccdbf9b29801e17569064bb867 * Copybara import of the project: -- a47b5b3 by Lachlan Roberts <[email protected]>: fix JSPs from appengine-local-runtime-shared-jetty12 Signed-off-by: Lachlan Roberts <[email protected]> COPYBARA_INTEGRATE_REVIEW=#350 from GoogleCloudPlatform:DevAppServer-JSP a47b5b3 PiperOrigin-RevId: 736601363 Change-Id: I231efd68881ea23227d1f8d1a21749cc02b71d0e * Update all non-major dependencies --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Lachlan Roberts <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abhinand Sundararajan <[email protected]> Co-authored-by: GAE Java Team <[email protected]> Co-authored-by: Lachlan Roberts <[email protected]> Co-authored-by: Srinjoy Ray <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Lachlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package name of
jetty-servletsclasses has changed from Jetty 9.4 to Jetty 12.This PR allows applications to use the old
jetty-servletsclass names, for exampleorg.eclipse.jetty.servlets.CrossOriginFilterwould be translated toorg.eclipse.jetty.ee8.servlets.CrossOriginFilterfor the EE8 environment.