allow use of old package name for ResourceFileServlet #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
Mar 20, 2025
|
Should we also do this mapping for all servlets and filters in |
|
@ludoch yes we should Looks like the only other ones are I think I could just do the entire |
Signed-off-by: Lachlan Roberts <[email protected]>
ludoch
approved these changes
Mar 20, 2025
|
Still test issues... |
Signed-off-by: Lachlan Roberts <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
…FileServlet PiperOrigin-RevId: 738673566 Change-Id: I5f50385a427b5d5ca4b77f586f33fd13587aeff5
maigovannon
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
com.google.apphosting.runtime.jetty9.ResourceFileServletto be used for apps on Java 21 runtime using EE8, even though package name has changed tocom.google.apphosting.runtime.jetty.ee8.ResourceFileServlet.Remove
DEPRECATED_PACKAGE_NAMESvalues for EE10, as code changes and redeployment are required to upgrade to EE10.