Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ndb.key.urlsafe() should return a string not bytes #71 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ndb.key.urlsafe() should return a string not bytes #71 #72

wants to merge 3 commits into from

Conversation

martin-green
Copy link

Fixes #71

  • Tests pass

@google-cla
Copy link

google-cla bot commented Mar 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoch ludoch requested review from asriniva and shreejad and removed request for asriniva March 28, 2023 18:35
@ludoch
Copy link
Collaborator

ludoch commented Mar 28, 2023

Hi,
Thanks for the PR. Can you update the missing CLA step?

@martin-green
Copy link
Author

martin-green commented Mar 28, 2023 via email

@martin-green martin-green mentioned this pull request May 24, 2023
Closed
@kamilturek
Copy link

Hey @ludoch, is there any update on this? I am curious about this change as it would mean drifting away from the Cloud NDB behaviour (which also returns bytes).

https://github.com/googleapis/python-ndb/blob/main/MIGRATION_NOTES.md#:~:text=Key.urlsafe%20outputs,in%20NDB%20behavior.

@shreejad
Copy link
Contributor

Please refer to #71 (comment)

TL;DR: This is a breaking change and will create divergent behaviors with Cloud NDB, who also choose to return bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreejad shreejad Awaiting requested review from shreejad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ndb.key.urlsafe() should return a string not bytes
4 participants
@martin-green @ludoch @kamilturek @shreejad