Thanks to visit codestin.com
Credit goes to github.com

Skip to content

libraries-bom: google-cloud-bom 0.169.0#2290

Merged
suztomo merged 2 commits into
masterfrom
gcb_0.168.1
Mar 2, 2022
Merged

libraries-bom: google-cloud-bom 0.169.0#2290
suztomo merged 2 commits into
masterfrom
gcb_0.168.1

Conversation

@suztomo

@suztomo suztomo commented Mar 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The new version of Google Cloud BOM has been released today. The shared dependencies BOM version remains the same (2.7.0) since the last Google Cloud BOM release.

@suztomo suztomo requested a review from a team March 1, 2022 00:55
@suztomo

suztomo commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author 
[INFO] Running com.google.cloud.MaximumLinkageErrorsTest
Mar 01, 2022 1:04:53 AM com.google.cloud.tools.opensource.classpath.LinkageChecker create
SEVERE: com.google.api.grpc:proto-google-cloud-firestore-bundle-v1:jar:3.0.13 was not resolved. Dependency path: null > com.google.api.grpc:proto-google-cloud-firestore-bundle-v1:jar:3.0.13 (compile)
Mar 01, 2022 1:04:53 AM com.google.cloud.tools.opensource.classpath.LinkageChecker create
SEVERE: com.google.api.grpc:google-cloud-firestore-admin:jar:3.0.13 was not resolved. Dependency path: null > com.google.api.grpc:google-cloud-firestore-admin:jar:3.0.13 (compile)
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 202.965 s <<< FAILURE! - in com.google.cloud.MaximumLinkageErrorsTest
Error:  testForNewLinkageErrors(com.google.cloud.MaximumLinkageErrorsTest)  Time elapsed: 202.965 s  <<< ERROR!
java.io.IOException: Could not resolve 2 dependencies. See the message above for details.

@Neenu1995

Neenu1995 commented Mar 1, 2022

Copy link
Copy Markdown

Both these dependencies are located in com.google.cloud in maven and not in com.google.api.grpc as indicated by groupID in the error log above.

proto-google-cloud-firestore-bundle-v1:jar:3.0.13
google-cloud-firestore-admin:jar:3.0.13

The POMs have no explicit groupIDs defined. It probably inherited from the parent. How come this was not an issue before?

@suztomo

suztomo commented Mar 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Neenu1995 This commit by Owlbot messed up google-cloud-firestore-bom 14 days ago.
googleapis/java-firestore@0350d16#diff-a081e19649d1297de665dfd47900d66df9a241d4a8b50030592f7850da97acbdR59

@Neenu1995

Neenu1995 commented Mar 1, 2022

Copy link
Copy Markdown

Fix on the way googleapis/java-firestore#890

@suztomo suztomo changed the title libraries-bom: google-cloud-bom 0.168.1 libraries-bom: google-cloud-bom 0.169.0 Mar 1, 2022
@sonarqubecloud

sonarqubecloud Bot commented Mar 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@suztomo suztomo added the kokoro:run force run kokoro label Mar 2, 2022
@cloud-tools-for-java-team cloud-tools-for-java-team removed the kokoro:run force run kokoro label Mar 2, 2022
@suztomo suztomo merged commit 91bc3a6 into master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@meltsufin meltsufin meltsufin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @Neenu1995 @meltsufin @cloud-tools-for-java-team