Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: refactor tools for easily locating registered tools#123

Merged
shruti-mantri merged 4 commits into
GoogleCloudPlatform:mainfrom
shruti-mantri:refactoring-tools
Aug 27, 2025
Merged

feat: refactor tools for easily locating registered tools#123
shruti-mantri merged 4 commits into
GoogleCloudPlatform:mainfrom
shruti-mantri:refactoring-tools

Conversation

@shruti-mantri
Copy link
Copy Markdown
Collaborator

Refactoring the code which helps in:

  1. Avoid code duplication when the same tool needs to be registered in local and remote tool registry
  2. Easy to understand and locate registered tools
  3. Reduce the tools.js file size which was crossing 1000 lines of code

@shruti-mantri
Copy link
Copy Markdown
Collaborator Author

Tested locally that the server is running as expected.

@steren
Copy link
Copy Markdown
Collaborator

steren commented Aug 25, 2025

Looks like the tests are failing: https://github.com/GoogleCloudPlatform/cloud-run-mcp/actions/runs/17218914843/job/48849291614?pr=123

Can you make sure tests pass?

Copy link
Copy Markdown
Collaborator

@steren steren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread tools/register_tools.js
Comment thread tools/register_tools.js Outdated
Comment thread tools/register_tools.js
@shruti-mantri shruti-mantri merged commit ba9e5bd into GoogleCloudPlatform:main Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants