Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add additional billing account checks before enabling any api #3#196

Merged
riddhi-shivhare merged 6 commits into
GoogleCloudPlatform:mainfrom
riddhi-shivhare:add-additional-billing-checks
Jan 13, 2026
Merged

fix: add additional billing account checks before enabling any api #3#196
riddhi-shivhare merged 6 commits into
GoogleCloudPlatform:mainfrom
riddhi-shivhare:add-additional-billing-checks

Conversation

@riddhi-shivhare
Copy link
Copy Markdown
Collaborator

feat: Add Additional billing account check before enabling apis

Implements checks within ensureApisEnabled to verify project billing status.
If billing is not enabled, the function attempts to automatically resolve the issue:

  1. Lists available billing accounts.
  2. If exactly one open billing account is found, it attaches the project to this account.
  3. Provides informative error messages and instructions for manual intervention if automatic attachment is not possible (e.g., no accounts, multiple accounts, or no open accounts).

ex - https://screenshot.googleplex.com/44vvzE2WKptxA4p

@riddhi-shivhare riddhi-shivhare force-pushed the add-additional-billing-checks branch from 78cfbd5 to 459c6ed Compare January 5, 2026 10:35
@riddhi-shivhare riddhi-shivhare marked this pull request as ready for review January 5, 2026 10:37
Comment thread lib/cloud-api/billing.js Outdated
Comment thread lib/cloud-api/helpers.js Outdated
Comment thread lib/cloud-api/helpers.js Outdated
Comment thread lib/cloud-api/helpers.js Outdated
Copy link
Copy Markdown
Member

@husainhirani husainhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add fix: prefix to commit message.

@riddhi-shivhare riddhi-shivhare changed the title add additional billing account checks before enabling any api #3 fix: add additional billing account checks before enabling any api #3 Jan 6, 2026
riddhi-shivhare added a commit to riddhi-shivhare/cloud-run-mcp that referenced this pull request Jan 8, 2026
@riddhi-shivhare riddhi-shivhare force-pushed the add-additional-billing-checks branch from 3e66cd3 to 1c73594 Compare January 8, 2026 06:18
Comment thread lib/cloud-api/billing.js Outdated
@riddhi-shivhare riddhi-shivhare force-pushed the add-additional-billing-checks branch from 1c73594 to 447c6fa Compare January 9, 2026 10:17
riddhi-shivhare added a commit to riddhi-shivhare/cloud-run-mcp that referenced this pull request Jan 9, 2026
Comment thread lib/cloud-api/billing.js Outdated
Comment thread test/local/helpers.test.js Outdated
Comment thread test/local/helpers.test.js Outdated
@riddhi-shivhare riddhi-shivhare force-pushed the add-additional-billing-checks branch from 9c570d2 to 066a1da Compare January 13, 2026 10:38
@riddhi-shivhare riddhi-shivhare merged commit 6de7d05 into GoogleCloudPlatform:main Jan 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants