refactor: add domain_name to ConnectionName class
#1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Dec 5, 2024
| import pytest # noqa F401 Needed to run the tests | ||
|
|
||
| from google.cloud.sql.connector.connection_name import _parse_instance_connection_name | ||
| # fmt: off |
There was a problem hiding this comment.
import style of long import names differs between isort and black format, turning black formatter off for these imports to stop lint job from complaining.
hessjcg
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
domain_nametoConnectionNamedataclass.PR also updates
_parse_connection_nameto wrap new_parse_connection_name_with_domain_nameto account fordomain name.
Part of #1169