build: update package to use pyproject.toml #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace_packages = true | ||
| ignore_missing_imports = true | ||
| warn_unused_configs = true | ||
| exclude = ['docs/*', 'samples/*'] |
There was a problem hiding this comment.
Just curious: are we currently excluding docs/* and samples/* in .mypy.ini. I don't see that we're excluding those there.
There was a problem hiding this comment.
nope, just copied the guidance from the google api core PR
rhatgadkar-goog
approved these changes
Feb 3, 2025
hessjcg
approved these changes
Feb 3, 2025
jackwotherspoon
added a commit
that referenced
this pull request
Feb 12, 2025
In #1230 we moved package off of setup.py and over to pyproject.toml Forgot a spot to update in release.sh which references setup.py which no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package to use
pyproject.tomlover soon to be deprecatedsetup.pyandsetup.cfgFixes #989