refactor: Use new ConnectSettings.DnsNames field to validate the server TLS certificate. #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f5aeb5 to
5153e7c
Compare
jackwotherspoon
requested changes
Mar 12, 2025
There was a problem hiding this comment.
@hessjcg Is the plan to manually test all these PRs? We need to make sure we do not break PSC with these changes.
tests/unit/mocks.py
Outdated
| "expirationTime": str(self.cert_expiration), | ||
| }, | ||
| "dnsName": "abcde.12345.us-central1.sql.goog", | ||
| "dnsNames": [ |
There was a problem hiding this comment.
we probably should also test that no dnsNames (fallback options) also still works...
I am fine if you would rather create a new issue on the repo to track improving testing (rotate certs, dnsName fallback test, etc.) with some details.
There was a problem hiding this comment.
Updated to test both paths. Also I added test in test_instance.py for legacy dns name.
5153e7c to
73246b8
Compare
…er TLS certificate.
73246b8 to
bbd29ad
Compare
jackwotherspoon
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the connector is configured with a DNS name, or if the Cloud SQL Instance reports that it has a DNS Name,
the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's
TLS certificate must contain a SAN record with the instance's DNS name.
The ConnectSettings API added a field dns_names which contains all of the valid DNS names for
an instance.
See also: GoogleCloudPlatform/cloud-sql-go-connector#954