Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix!: consolidate to 'ip_type' instead of 'ip_types' for connect args #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 4, 2022
Merged

fix!: consolidate to 'ip_type' instead of 'ip_types' for connect args #220

merged 5 commits into from
Jan 4, 2022

Conversation

jackwotherspoon
Copy link
Collaborator

Wait until right before next release to merge. That way README and Pypi package will be consistent with eachother.

@jackwotherspoon jackwotherspoon added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2021
@jackwotherspoon jackwotherspoon self-assigned this Dec 10, 2021
@jackwotherspoon jackwotherspoon linked an issue Dec 10, 2021 that may be closed by this pull request
Change 'ip_types' Connector parameter to 'ip_type'. #212
Closed
@kurtisvg kurtisvg changed the title chore: update Connector and README with 'ip_type' param fix!: consolidate to 'ip_type' instead of 'ip_types' for connect args Dec 10, 2021
@jackwotherspoon jackwotherspoon removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 4, 2022
@jackwotherspoon jackwotherspoon merged commit 5f9cf58 into main Jan 4, 2022
@jackwotherspoon jackwotherspoon deleted the ip_type-param branch January 4, 2022 19:39
This was referenced Jan 4, 2022
Closed
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jan 27, 2022
Open
@github-actions github-actions bot mentioned this pull request May 17, 2022
Open
@jackwotherspoon jackwotherspoon mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change 'ip_types' Connector parameter to 'ip_type'.
2 participants
@jackwotherspoon @kurtisvg