Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

kenneth-rosario
Copy link

@kenneth-rosario kenneth-rosario commented Jul 11, 2023

The new -builder-url flag will help improve test coverage for oss builders that claim to support functions framework.

@kenneth-rosario kenneth-rosario marked this pull request as ready for review July 11, 2023 21:41
garethgeorge
garethgeorge previously approved these changes Jul 12, 2023
@kenneth-rosario kenneth-rosario marked this pull request as draft July 12, 2023 17:43
@kenneth-rosario kenneth-rosario dismissed garethgeorge’s stale review July 12, 2023 17:43

Will implement latest idea suggested.

@kenneth-rosario kenneth-rosario force-pushed the kennethrosario/add-builder-url-flag branch 10 times, most recently from 31583b8 to e55e102 Compare July 12, 2023 20:20
@kenneth-rosario kenneth-rosario marked this pull request as ready for review July 12, 2023 20:27
@kenneth-rosario
Copy link
Author

kenneth-rosario commented Jul 12, 2023

@garethgeorge I was able to add dynamic matrix capability. Unfortunately, I was not able to find GitHub Action support for plain string array on inputs. Had to resort on using a json string array .

@garethgeorge
Copy link
Contributor

garethgeorge commented Jul 12, 2023

Sorry for the confusion @kenneth-rosario, hope I'm not making you go back and forth. Will the value need to be overridden? If it does, I think I prefer your original solution (I think the operation can be run in a matrix in whatever workflow invokes it?). Otherwise, I'm wondering if we can just hard code it in a central place (i.e. here in the conformance test repo) and do away with the input all together.

@kenneth-rosario
Copy link
Author

Ah I see, apologies for misunderstanding will go back to last implementation. I am not sure if its possible to have them all centralized since some of the builders are runtime specific. (e.g. "gcr.io/gae-runtimes/buildpacks/go/builder:latest", "gcr.io/gae-runtimes/buildpacks/google-gae-22/go/builder:latest") We might end up spawning too many runners that do not run (Or might fail).

@kenneth-rosario kenneth-rosario marked this pull request as draft July 12, 2023 20:55
@kenneth-rosario kenneth-rosario force-pushed the kennethrosario/add-builder-url-flag branch from e55e102 to 48525b9 Compare July 12, 2023 20:56
@garethgeorge
Copy link
Contributor

Nice, thanks Kenneth!

@kenneth-rosario kenneth-rosario marked this pull request as ready for review July 12, 2023 21:00
@kenneth-rosario kenneth-rosario merged commit 64d4646 into master Jul 12, 2023
@kenneth-rosario kenneth-rosario deleted the kennethrosario/add-builder-url-flag branch July 12, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants