Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: use structured logging for exceptions #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021
Merged

feat: use structured logging for exceptions #278

merged 2 commits into from
Feb 19, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 19, 2021

Log exceptions from the application using structured logging so they are
reported to the right places.

Fixes #275

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #278 (df559cd) into main (439e35c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   90.25%   90.27%   +0.01%     
==========================================
  Files          83       83              
  Lines        2094     2098       +4     
==========================================
+ Hits         1890     1894       +4     
  Misses        204      204              
Impacted Files Coverage Δ
...ctions/integration_tests/basic_integration_test.cc 91.66% <100.00%> (+0.11%) ⬆️
.../integration_tests/cloud_event_integration_test.cc 95.62% <100.00%> (+0.03%) ⬆️
...gle/cloud/functions/internal/call_user_function.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439e35c...8298825. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 19, 2021 13:25
@coryan coryan requested a review from a team as a code owner February 19, 2021 13:25
Log exceptions from the application using structured logging so they are
reported to the right places.
@coryan
Copy link
Contributor Author

coryan commented Feb 19, 2021

PTAL

@coryan coryan merged commit 898e5e2 into GoogleCloudPlatform:main Feb 19, 2021
@coryan coryan deleted the feat-use-structured-logging branch February 19, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use structured logging for the framework logs
2 participants