feat: add better handling for exceptions #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
requested changes
Nov 6, 2020
Comment on lines
+46
to
+48
| throw new \LogicException( | ||
| 'Function response must be string or ' . ResponseInterface::class | ||
| ); |
There was a problem hiding this comment.
I like the increased certainty this provides. Good idea!
| 'Invalid signature type: "%s"', $signatureType)); | ||
| } | ||
| $this->errorLogFunc = function (string $error) { | ||
| fwrite(fopen('php://stderr', 'wb'), json_encode([ |
There was a problem hiding this comment.
Will this error also get routed to Error Reporting on Cloud Functions? (Sending further context in chat.)
There was a problem hiding this comment.
We need to manually test. If it doesn't work, we might not want to make the change.
src/Invoker.php
Outdated
| : 'error'; | ||
| return new Response(200, [ | ||
| FunctionWrapper::FUNCTION_STATUS_HEADER => $statusHeader, | ||
| ], $e->getMessage()); |
There was a problem hiding this comment.
This error message might surface implementation details of the function, maybe it should respect display_errors?
There was a problem hiding this comment.
Yes, I am also okay omitting it to be safe. I was following Node's implementation.
There was a problem hiding this comment.
I've removed the error from the response for simplicity for now
grayside
reviewed
Nov 6, 2020
grayside
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #60
The invoker catches all throwables of type
Exception(note:Errortypes are not handled).The invoker then sets:
200X-Google-Statusresponse header to "error" (cloudevent) or "crash" (http)The invoker logs an error to
stderrwith a json-formatted stack trace.Other notes:
LogicException