Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update background to CloudEvent conversion #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2021
Merged

Update background to CloudEvent conversion #73

merged 4 commits into from
Mar 9, 2021

Conversation

mtraver
Copy link
Contributor

@mtraver mtraver commented Mar 9, 2021

Also enable background to CloudEvent mapping validation in conformance test config.

@mtraver mtraver requested review from bshaffer and grant March 9, 2021 04:43
bshaffer
bshaffer reviewed Mar 9, 2021
View reviewed changes
bshaffer
bshaffer requested changes Mar 9, 2021
View reviewed changes
bshaffer
bshaffer reviewed Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code cleanup but otherwise this is looking really good.

@bshaffer bshaffer merged commit 1bf9f42 into master Mar 9, 2021
@bshaffer bshaffer deleted the event-conversion branch March 9, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

+1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtraver @bshaffer @grant