Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to use shared data bucket for import test in Product Search #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Update to use shared data bucket for import test in Product Search #1303

wants to merge 9 commits into from

Conversation

nirupa-kumar
Copy link
Contributor

@nirupa-kumar nirupa-kumar commented Dec 19, 2018 •
edited
Loading

  • Fixed the importProductSets test to use the csv file in the shared bucket.
  • Added note for the pre-created product set requirement for Similar Product Search

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@nirupa-kumar
Copy link
Contributor Author

@nnegrey
Please review

dzlier-gcp
dzlier-gcp previously approved these changes Jan 10, 2019
View reviewed changes
@dzlier-gcp dzlier-gcp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2019
@dzlier-gcp
Copy link
Member

I just updated this to match master branch, and the tests now fail consistently. Please review the test logs.

@kurtisvg kurtisvg dismissed dzlier-gcp’s stale review February 8, 2019 19:03

tests failing after update

@kurtisvg
Copy link
Contributor

kurtisvg commented Feb 8, 2019

@nirupa-kumar @nnegrey PTAL at the tests

@nirupa-kumar nirupa-kumar requested a review from a team February 8, 2019 19:18
@nirupa-kumar
Copy link
Contributor Author

working on trying to fix the flakiness.

@kurtisvg
Copy link
Contributor

@nnegrey Is this PR still needed or can we close it out?

@nnegrey
Copy link
Contributor

nnegrey commented Jun 12, 2019

Oh gosh, um I should probably pick this up.

@nnegrey nnegrey mentioned this pull request Jun 18, 2019
Merged
@nnegrey nnegrey closed this Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzlier-gcp dzlier-gcp dzlier-gcp left review comments

Assignees

@nnegrey nnegrey

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirupa-kumar @dzlier-gcp @kurtisvg @nnegrey @googlebot @kokoro-team