Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Container analysis filter #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2019
Merged

Container analysis filter #1415

merged 5 commits into from
May 14, 2019

Conversation

daniel-sanche
Copy link
Member

Two small fixes:

  • I changed the filter string that is exposed in the docs to be more precise, but used region tags to invisibly fall back to the original filter since the new one can't be easily tested
  • I renamed PubSub.java to Subscriptions.java. It seems PubSub was causing warnings in the docs CLs, since the proper name is Pub/Sub

@daniel-sanche daniel-sanche requested a review from a team May 13, 2019 18:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2019
@daniel-sanche daniel-sanche merged commit e2c0229 into GoogleCloudPlatform:master May 14, 2019
@daniel-sanche daniel-sanche deleted the container-analysis-filter branch May 14, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-sanche @lesv @googlebot