Cloud Run + Cloud Endpoints #3406

aubreyyan · 2020-07-23T04:06:01Z

It's a good idea to open an issue first for discussion.

I have followed Sample Format Guide
pom.xml parent set to latest shared-configuration
Appropriate changes to README are included in PR
API's need to be enabled to test (tell us)
Environment Variables need to be set (ask us to set them)
Tests pass: mvn clean verify required
Lint passes: mvn -P lint checkstyle:check required
Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
Please merge this PR for me once it is approved.

mvn clean verify

aubre@DESKTOP-F4APIAI ~/Projects/java-docs-samples/run/endpoints-v2-backend (run-endpoints)
$ mvn clean verify
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------------< com.example:endpoints >------------------------
[INFO] Building rest 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ endpoints ---
[INFO] Deleting /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.5:prepare-agent (default) @ endpoints ---
[INFO] argLine set to -javaagent:/mnt/c/Users/aubre/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target/jacoco.ex
ec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ endpoints ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ endpoints ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target/classes
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ endpoints ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ endpoints ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (default-test) @ endpoints ---
[INFO] No tests to run.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.5:report (report) @ endpoints ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ endpoints ---
[INFO] Building jar: /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target/endpoints-1.0-SNAPSHOT.jar
[INFO]
[INFO] --- spring-boot-maven-plugin:2.3.1.RELEASE:start (pre-integration-test) @ endpoints ---
[INFO] Attaching agents: []
.   ____          _            __ _ _

/\ / ' __ _ () __  __ _ \ \ \ 

( ( )__ | '_ | '| | ' / ` | \ \ \ 

\/  )| |)| | | | | || (| |  ) ) ) )

'  || .__|| ||| |_, | / / / /

=========||==============|/=////

:: Spring Boot ::        (v2.3.1.RELEASE)
2020-07-22 23:44:57.590  INFO 23566 --- [           main] c.e.endpoints.EndpointsApplication       : Starting EndpointsApplication on DESKTOP-F4APIAI with PID 23566 (/mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-bac

kend/target/classes started by aubre in /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend)

2020-07-22 23:44:57.597  INFO 23566 --- [           main] c.e.endpoints.EndpointsApplication       : No active profile set, falling back to default profiles: default

2020-07-22 23:45:01.012  INFO 23566 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 8080 (http)

2020-07-22 23:45:01.042  INFO 23566 --- [           main] o.apache.catalina.core.StandardService   : Starting service [Tomcat]

2020-07-22 23:45:01.042  INFO 23566 --- [           main] org.apache.catalina.core.StandardEngine  : Starting Servlet engine: [Apache Tomcat/9.0.36]

2020-07-22 23:45:01.397  INFO 23566 --- [           main] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext

2020-07-22 23:45:01.397  INFO 23566 --- [           main] w.s.c.ServletWebServerApplicationContext : Root WebApplicationContext: initialization completed in 3661 ms

2020-07-22 23:45:02.025  INFO 23566 --- [           main] o.s.s.concurrent.ThreadPoolTaskExecutor  : Initializing ExecutorService 'applicationTaskExecutor'

2020-07-22 23:45:03.723  INFO 23566 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 8080 (http) with context path ''

2020-07-22 23:45:03.753  INFO 23566 --- [           main] c.e.endpoints.EndpointsApplication       : Started EndpointsApplication in 7.509 seconds (JVM running for 9.314)

[INFO]

[INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (default) @ endpoints ---

[INFO] No tests to run.

[INFO]

[INFO] --- springdoc-openapi-maven-plugin:1.0:generate (integration-test) @ endpoints ---

2020-07-22 23:45:06.712  INFO 23566 --- [nio-8080-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring DispatcherServlet 'dispatcherServlet'

2020-07-22 23:45:06.713  INFO 23566 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet        : Initializing Servlet 'dispatcherServlet'

2020-07-22 23:45:06.728  INFO 23566 --- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet        : Completed initialization in 15 ms

2020-07-22 23:45:07.120  INFO 23566 --- [nio-8080-exec-1] o.springdoc.api.AbstractOpenApiResource  : Init duration for springdoc-openapi is: 280 ms

[INFO]

[INFO] --- openapi-converter-maven-plugin:1.0.0-SNAPSHOT:convertOpenApiDocs (integration-test) @ endpoints ---

[INFO]

[INFO] --- spring-boot-maven-plugin:2.3.1.RELEASE:stop (post-integration-test) @ endpoints ---

[INFO] Stopping application...

2020-07-22 23:45:08.039  INFO 23566 --- [on(2)-127.0.0.1] inMXBeanRegistrar$SpringApplicationAdmin : Application shutdown requested.

2020-07-22 23:45:08.083  INFO 23566 --- [on(2)-127.0.0.1] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'

[INFO]

[INFO] --- maven-failsafe-plugin:3.0.0-M4:verify (default) @ endpoints ---

[INFO] ------------------------------------------------------------------------

[INFO] BUILD SUCCESS

[INFO] ------------------------------------------------------------------------

[INFO] Total time:  38.060 s

[INFO] Finished at: 2020-07-22T23:45:08-04:00

[INFO] ------------------------------------------------------------------------

mvn -P lint checkstyle:check

aubre@DESKTOP-F4APIAI ~/Projects/java-docs-samples/run/endpoints-v2-backend (run-endpoints)
$ mvn -P lint checkstyle:check
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------------< com.example:endpoints >------------------------
[INFO] Building rest 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.1:check (default-cli) @ endpoints ---
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.978 s
[INFO] Finished at: 2020-07-22T23:57:47-04:00
[INFO] ------------------------------------------------------------------------

mvn -P lint clean compile pmd:cpd-check spotbugs:check

aubre@DESKTOP-F4APIAI ~/Projects/java-docs-samples/run/endpoints-v2-backend (run-endpoints)
$ mvn -P lint clean compile pmd:cpd-check spotbugs:check
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------------< com.example:endpoints >------------------------
[INFO] Building rest 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ endpoints ---
[INFO] Deleting /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.5:prepare-agent (default) @ endpoints ---
[INFO] argLine set to -javaagent:/mnt/c/Users/aubre/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target/jacoco.ex
ec
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ endpoints ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ endpoints ---
...
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 2 source files to /mnt/c/Users/aubre/Projects/java-docs-samples/run/endpoints-v2-backend/target/classes
[INFO]
[INFO] >>> spotbugs-maven-plugin:4.0.0:check (analyze-compile) > :spotbugs @ endpoints >>>
[INFO]
[INFO] --- spotbugs-maven-plugin:4.0.0:spotbugs (spotbugs) @ endpoints ---
...
[INFO] Done SpotBugs Analysis....
[INFO]
[INFO] <<< spotbugs-maven-plugin:4.0.0:check (analyze-compile) < :spotbugs @ endpoints <<<
[INFO]
[INFO]
[INFO] --- spotbugs-maven-plugin:4.0.0:check (analyze-compile) @ endpoints ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[ERROR] com.example.endpoints.controllers.RepeatController is a Spring endpoint (Controller) [com.example.endpoints.controllers.RepeatController] At RepeatController.java:[lines 34-40] SPRING_ENDPOINT
[ERROR] Method com.example.endpoints.controllers.RepeatController.repeat(String, Integer) passes constant String of length 1 to character overridden method [com.example.endpoints.controllers.RepeatController] At RepeatController.jav
a:[line 38] UCPM_USE_CHARACTER_PARAMETERIZED_METHOD
[INFO]
To see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"
[INFO] ------------------------------------------------------------------------

[INFO] ------------------------------------------------------------------------

[INFO] BUILD FAILURE

[INFO] ------------------------------------------------------------------------

[INFO] Total time:  01:11 min

[INFO] Finished at: 2020-07-23T00:00:14-04:00

[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check (analyze-compile) on project endpoints: failed with 2 bugs and 0 errors  -> [Help 1]

[ERROR]

[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR]

[ERROR] For more information about the errors and possible solutions, please read the following articles:

[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

~~This pull request is not final. I wanted to get the functional part of the code approved before writing a detailed instructional README.~~

…un-endpoints

lesv · 2020-07-23T17:57:46Z

I'm reassigning to @averikitsch to review since she's been talking w/ @Aubrey-Y - I'd be particularly careful of how this get's tested including that script.

aubreyyan · 2020-07-23T18:02:43Z

If we didn't want to go down that route, which is always an option, an alternative is for the user to just download a swagger 2.0 openapi.json but I haven't explored that avenue. Of course nothing's set in stone and the highest priority is making sure everyone is fully satisfied with how everything works.

averikitsch · 2020-07-30T21:54:14Z

@Aubrey-Y sorry for the slow review. I'm hoping to get to this by the EOW.

averikitsch

Hi @Aubrey-Y, thank you again for this contribution. I am impressed by the steps you have created to create the yaml file. Although I am debating if this would be too confusing to teach to others. I would argue for simplifying this a bit by removing your plugin and showing how the spring openapi plugin can get you close to what you need.

Please add a README structured similarly to our other run samples (example).

This should link to https://cloud.google.com/endpoints/docs/openapi/get-started-cloud-run for further instructions on running this sample.
It should have a step for replacing the urls needed and running mvn verify to get the yaml. Then a note to update the yaml for the swagger 2.0 spec.
It should have a step for using jib to containerize the app.

Please add unit tests
Add a file like https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/run/pubsub/src/main/resources/application.properties

Thanks!

run/endpoints-v2-backend/pom.xml

run/endpoints-v2-backend/gcloud_build_image

run/endpoints-v2-backend/.gitignore

.gitignore

run/endpoints-v2-backend/pom.xml

run/endpoints-v2-backend/openapi-run.yaml

aubreyyan · 2020-08-12T19:44:35Z

Hi @Aubrey-Y, thank you again for this contribution. I am impressed by the steps you have created to create the yaml file. Although I am debating if this would be too confusing to teach to others. I would argue for simplifying this a bit by removing your plugin and showing how the spring openapi plugin can get you close to what you need.

Please add a README structured similarly to our other run samples (example).

This should link to https://cloud.google.com/endpoints/docs/openapi/get-started-cloud-run for further instructions on running this sample.

It should have a step for replacing the urls needed and running mvn verify to get the yaml. Then a note to update the yaml for the swagger 2.0 spec.

It should have a step for using jib to containerize the app.

Please add unit tests

Add a file like https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/run/pubsub/src/main/resources/application.properties

Thanks!

@averikitsch is application.yml format okay or it must be .properties?

aubreyyan · 2020-08-12T20:02:00Z

Also, for unit testing, since there is not much function to the controller, would a unit test or two suffice?

averikitsch · 2020-08-12T20:10:28Z

Also, for unit testing, since there is not much function to the controller, would a unit test or two suffice?

Yeah, one for the controller and one for /v3/api-docs.yaml would be nice.

aubreyyan · 2020-08-12T20:56:13Z

I think you missed my earlier question @averikitsch

…un-endpoints

aubreyyan · 2020-09-21T21:06:17Z

@lesv @averikitsch just giving this a bump

I should note this is in Java 11, not Java 8. I saw some activity in another thread about it so let me know if that should change.

averikitsch · 2020-10-19T17:38:07Z

run/endpoints-v2-backend/src/test/resources/application.yml

@@ -0,0 +1,15 @@
+#  Copyright 2020 Google LLC


This file shouldn't be needed, since found run/endpoints-v2-backend/src/main/resources/application.yml

okay, i will delete application.yml - that means theres no properties file

unless by "this file" you mean application.properties?

You have this both in /src/main/resources and /src/test/resources only the file in /src/main/resources is needed

averikitsch · 2020-10-19T17:43:58Z

run/endpoints-v2-backend/README.md

+    file openapi-run.yaml in this demo project. If you are using an IDE like IntelliJ IDEA Ultimate, after switching the
+    version number to 2.0, it should tell you what's wrong with the file.
+    
+1. Follow the [Getting Started with Endpoints for Cloud Run with ESPv2](https://cloud.google.com/endpoints/docs/openapi/get-started-cloud-run)


I believe at this point it should start at Deploying the Endpoints configuration

averikitsch · 2020-10-19T17:44:52Z

run/endpoints-v2-backend/README.md

+    </properties>
+    ```
+
+1. Update `<YOUR_HOST_HERE>` and `<YOUR_APP_URI_HERE>` in EndpointsApplication.java.


Need more information for these variables. Probably should add that the users needs to follow this section first Reserving a Cloud Run hostname

run/endpoints-v2-backend/README.md

averikitsch

Sorry for the late review.

Co-authored-by: Averi Kitsch <[email protected]>

aubreyyan · 2020-10-29T16:32:03Z

@averikitsch
I totally get it, things have been strenuous as of late for me as well.

I made all of the changes requested with the exception of application.yml - waiting for clarification on that point above

run/endpoints-v2-backend/README.md

averikitsch · 2020-10-30T15:30:22Z

[ERROR] src/test/java/com/example/controllers/RepeatControllerTest.java:[24,1] (imports) CustomImportOrder: Import statement for 'org.junit.jupiter.api.Assertions.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[29,1] (imports) CustomImportOrder: Import statement for 'org.junit.jupiter.api.Assertions.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[57] (sizes) LineLength: Line is longer than 100 characters (found 104).
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[79,45] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[80,19] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[81,41] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[82,27] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[83,22] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[84,40] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[85,49] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[86,20] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[87,31] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[88,22] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[89,25] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[90,39] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[91,39] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[92,31] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[93,32] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[94,31] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[95,36] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[96,29] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[97,36] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[98,33] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[99,31] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[100,36] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[101,29] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[102,37] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[103,37] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[104,30] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[105,30] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[106,39] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[107,32] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[108,32] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[109,35] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] src/test/java/com/example/controllers/RepeatControllerIT.java:[110,42] (whitespace) OperatorWrap: '+' should be on a new line.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project endpoints: You have 35 Checkstyle violations. -> [Help 1]

Co-authored-by: Averi Kitsch <[email protected]>

… into run-endpoints

averikitsch · 2020-10-30T18:19:02Z

run/endpoints-v2-backend/src/test/resources/application.yml

@@ -0,0 +1,15 @@
+#  Copyright 2020 Google LLC


Do you need this file for test purposes? If not delete

aubreyyan · 2020-11-03T21:15:07Z

i totally forgot to do that (again?) thanks for catching it

aubreyyan · 2020-11-03T21:33:19Z

is this a problem?

aubreyyan added 5 commits July 15, 2020 16:23

initial setup for run endpoints

dee5842

initial setup for run endpoints

d176e72

Merge remote-tracking branch 'upstream/master'

b8c6d6c

Merge branch 'master' of github.com:aubrey-y/java-docs-samples into r…

19d4f59

…un-endpoints

linting fixes

88881e5

aubreyyan requested a review from a team July 23, 2020 04:06

blunderbuss-gcf bot assigned lesv Jul 23, 2020

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020

lesv assigned averikitsch and unassigned lesv Jul 23, 2020

averikitsch requested changes Aug 12, 2020

View reviewed changes

aubreyyan force-pushed the run-endpoints branch from a43b523 to 741996f Compare August 25, 2020 16:02

copyright, testing, cleanup

9208039

aubreyyan force-pushed the run-endpoints branch from 741996f to 9208039 Compare August 25, 2020 16:04

README.md

b086746

aubreyyan force-pushed the run-endpoints branch from 7e7fca0 to b086746 Compare August 25, 2020 16:40

aubreyyan added 3 commits August 25, 2020 12:42

Merge remote-tracking branch 'upstream/master'

6737ec6

Merge branch 'master' of github.com:aubrey-y/java-docs-samples into r…

7e2801b

…un-endpoints

comments

20966f9

aubreyyan requested a review from averikitsch August 25, 2020 16:47

product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2020

averikitsch reviewed Oct 19, 2020

View reviewed changes

run/endpoints-v2-backend/README.md Outdated Show resolved Hide resolved

averikitsch reviewed Oct 19, 2020

View reviewed changes

aubreyyan and others added 2 commits October 29, 2020 12:09

Update run/endpoints-v2-backend/README.md

2120d5e

Co-authored-by: Averi Kitsch <[email protected]>

updated variable conventions

601c424

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2020

averikitsch reviewed Oct 30, 2020

View reviewed changes

run/endpoints-v2-backend/README.md Outdated Show resolved Hide resolved

aubreyyan and others added 3 commits October 30, 2020 13:11

Update run/endpoints-v2-backend/README.md

a9f51f3

Co-authored-by: Averi Kitsch <[email protected]>

fixed linting errors

4e76be8

Merge branch 'run-endpoints' of github.com:aubrey-y/java-docs-samples…

95440fa

… into run-endpoints

aubreyyan requested a review from averikitsch October 30, 2020 17:28

averikitsch reviewed Oct 30, 2020

View reviewed changes

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2020

Delete application.yml

b62a80f

averikitsch added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020

averikitsch approved these changes Nov 3, 2020

View reviewed changes

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020

gcf-merge-on-green bot merged commit 2754a0d into GoogleCloudPlatform:master Nov 3, 2020

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2020

Cloud Run + Cloud Endpoints #3406

Cloud Run + Cloud Endpoints #3406

Uh oh!

Conversation

aubreyyan commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesv commented Jul 23, 2020

Uh oh!

aubreyyan commented Jul 23, 2020

Uh oh!

averikitsch commented Jul 30, 2020

Uh oh!

averikitsch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aubreyyan commented Aug 12, 2020

Uh oh!

aubreyyan commented Aug 12, 2020

Uh oh!

averikitsch commented Aug 12, 2020

Uh oh!

aubreyyan commented Aug 12, 2020

Uh oh!

aubreyyan commented Sep 21, 2020

Uh oh!

averikitsch Oct 19, 2020

Choose a reason for hiding this comment

Uh oh!

aubreyyan Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

aubreyyan Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

averikitsch Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

averikitsch Oct 19, 2020

Choose a reason for hiding this comment

Uh oh!

averikitsch Oct 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

averikitsch left a comment

Choose a reason for hiding this comment

Uh oh!

aubreyyan commented Oct 29, 2020

Uh oh!

Uh oh!

averikitsch commented Oct 30, 2020

Uh oh!

averikitsch Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

aubreyyan commented Nov 3, 2020

Uh oh!

aubreyyan commented Nov 3, 2020

Uh oh!

Uh oh!

aubreyyan commented Jul 23, 2020 •

edited

Loading