Thanks to visit codestin.com
Credit goes to github.com

Skip to content

preview: fix crash on typed resources and hang on defaulting#7743

Merged
anhdle-sso merged 7 commits into
GoogleCloudPlatform:masterfrom
anhdle-sso:fix-preview-hang-and-crash
May 22, 2026
Merged

preview: fix crash on typed resources and hang on defaulting#7743
anhdle-sso merged 7 commits into
GoogleCloudPlatform:masterfrom
anhdle-sso:fix-preview-hang-and-crash

Conversation

@anhdle-sso

Copy link
Copy Markdown
Collaborator

Fixes #7742

@anhdle-sso anhdle-sso requested a review from justinsb April 30, 2026 21:31
Comment thread pkg/cli/preview/recorder.go Outdated
Comment thread pkg/cli/preview/recorder.go Outdated
Comment thread pkg/cli/preview/recorder.go Outdated
@anhdle-sso

Copy link
Copy Markdown
Collaborator Author

I have addressed the review comments by:

  1. Updating the recorder to accept and use a runtime.Scheme for GVK resolution.
  2. Using apiutil.GVKForObject instead of the custom reflection-based logic.
  3. Removing the redundant GVK resolution branches that were questioned.
  4. Passing the scheme from the client to the recorder in intercepting_kube_client.go.

@google-oss-prow google-oss-prow Bot added the lgtm label May 21, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldanielmadariaga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anhdle-sso anhdle-sso added this pull request to the merge queue May 22, 2026
Merged via the queue into GoogleCloudPlatform:master with commit 0a02d3a May 22, 2026
170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preview: tool crashes on typed resources and hangs on defaulting

3 participants