okf: rename enrichment_agent package to reference_agent#129
Merged
amirhormati merged 1 commit intoJun 21, 2026
Merged
Conversation
Reframes the OKF proof-of-concept agent as the reference agent to disambiguate it from other agents and to match how it is described in the README. All Python imports, ADK identifiers, CLI script, PyPI dist name, User-Agent string, prompt filename, and prose in READMEs are updated. SPEC.md is unchanged. Co-Authored-By: Claude Opus 4.7 <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
passionworkeer
pushed a commit
to passionworkeer/knowledge-catalog
that referenced
this pull request
Jun 25, 2026
OKF v0.1 §4.1 explicitly states that only `type` is REQUIRED; `title`, `description`, and `timestamp` are listed as Recommended. The reference implementation treated all four as REQUIRED, so any spec-minimal bundle whose concepts only declared `type` would be incorrectly rejected by OKFDocument.validate(). This hurts programmatic producers in particular — they often have no human-readable title/description available at generation time. This PR is a rebase of upstream GoogleCloudPlatform#64 onto the post-GoogleCloudPlatform#129 `enrichment_agent` → `reference_agent` rename: change one constant, update the corresponding test, and add a minimal-frontmatter acceptance test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enrichment_agenttoreference_agentto match the framing already used inokf/README.md("A reference agent that ingests metadata...") and to disambiguate from other agents in adjacent projects.okf_bq_reference_agent,reference_agent_bq,reference_agent_web), the CLI script (reference-agent), the PyPI dist name (reference-agent), the User-Agent string (okf-reference-agent/0.1), the prompt filename (reference_instruction.md), and prose inokf/README.mdand the three sample READMEs.SPEC.mdunchanged (the format is agent-agnostic) and leaves the ADK web agent identity (okf_web_ingestion_agent,web_ingestion_instruction.md) alone since "web ingestion" describes the phase rather than the agent identity.Test plan
rm -rf .venv && python3.13 -m venv .venv && .venv/bin/pip install -e .[dev]installs cleanly under the new dist name (pip show reference-agent→ 0.1.0)..venv/bin/pytest— 33/33 pass..venv/bin/reference-agent --helpexposesenrich+visualizesubcommands..venv/bin/python -m reference_agent visualize --bundle bundles/ga4 --out /tmp/ga4.htmlrenders the existing bundle (no API credentials required).grep -rn "enrichment_agent\|enrichment-agent" okf/is empty.