Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mistake in firestore numeric increment example for python #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fronbasal opened this issue Aug 29, 2019 · 3 comments · Fixed by #2427
Closed

Mistake in firestore numeric increment example for python #2374

fronbasal opened this issue Aug 29, 2019 · 3 comments · Fixed by #2427
Assignees
@BenWhitehead

Comments

@fronbasal
Copy link

fronbasal commented Aug 29, 2019 •
edited by BenWhitehead
Loading

In which file did you encounter the issue?

´python-docs-samples/firestore/cloud-client/snippets.py

Did you change the file? If so, how?

Line 884:

-washington_ref.update("population", firestore.Increment(50))
+washington_ref.update({"population": firestore.Increment(50)})

(the update parameters need to be passed as a dict)

Describe the issue

The original command raises an exception.
BenWhitehead added a commit that referenced this issue Oct 1, 2019
@BenWhitehead
fix: typo in fs_update_document_increment sample
b713dd9 
Fixes #2374
@BenWhitehead BenWhitehead mentioned this issue Oct 1, 2019
Merged
@BenWhitehead
Copy link
Contributor

Thanks for the heads up on this sample, I've posted a PR with the fix.

@fronbasal
Copy link
Author

Awesome. Thank you!

@fronbasal
Copy link
Author

I think we can close this issue now. Thanks to @BenWhitehead for writing the PR.

BenWhitehead added a commit that referenced this issue Oct 2, 2019
@BenWhitehead
fix: typo in fs_update_document_increment sample
9d64583 
Fixes #2374
andrewferlitsch pushed a commit that referenced this issue Oct 9, 2019
@BenWhitehead @andrewferlitsch
fix: typo in fs_update_document_increment sample (#2427)
44d1d15 
Fixes #2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWhitehead BenWhitehead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typo in fs_update_document_increment sample GoogleCloudPlatform/python-docs-samples
2 participants
@BenWhitehead @fronbasal