docs: Remove Grounded Generation Samples #13244
Conversation
There was a problem hiding this comment.
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request removes the Grounded Generation samples from discoveryengine/standalone_apis_sample.py and the corresponding tests from discoveryengine/standalone_apis_sample_test.py. The commit message references cl/737664955 for details, which I don't have access to, so I am unable to provide more context.
Highlights
- Removal of Grounded Generation Samples: The Grounded Generation samples have been removed from
discoveryengine/standalone_apis_sample.py. - Removal of Tests: The tests associated with the Grounded Generation samples have been removed from
discoveryengine/standalone_apis_sample_test.py.
Changelog
- discoveryengine/standalone_apis_sample.py
- Removed the
grounded_generation_inline_vais_sample,grounded_generation_google_search_sample, andgrounded_generation_streaming_samplefunctions. - Deleted lines 127-305, which contained the Grounded Generation samples.
- Removed the
- discoveryengine/standalone_apis_sample_test.py
- Removed the
test_grounded_generation_inline_vais_sampleandtest_grounded_generation_google_search_samplefunctions. - Removed import for
google.cloud.resourcemanager_v3which was no longer needed. - Deleted lines 39-60, which contained the Grounded Generation tests.
- Removed the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A sample departs, its code takes flight,
Grounded no more, in the fading light.
Tests disappear, a function's call,
Leaving the module, standing tall.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request removes the grounded generation samples from the standalone_apis_sample.py file and their corresponding tests in standalone_apis_sample_test.py. This seems to be related to a change in the backend, as indicated by the linked CL. The removal appears straightforward and the code is now cleaner.
Merge Readiness
The pull request removes the grounded generation samples and associated tests. Given the context provided by the CL, this change seems necessary. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Since there are no critical or high severity issues, the pull request seems ready to be merged.
|
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
This reverts commit 9e52ed6.
Description
See cl/737664955 for details