revert: "docs: Remove Grounded Generation Samples" #13564
Conversation
This reverts commit 9e52ed6.
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reverses a prior modification, restoring specific code samples and their associated tests related to grounded generation within the discoveryengine module. The primary purpose is to bring back functionality that was previously removed, ensuring the availability of these examples.
Highlights
- Revert of previous change: This pull request reverts the changes introduced in #13244, effectively reintroducing previously removed code.
- Reintroduction of Grounded Generation Samples: The standalone_apis_sample.py file now includes the grounded_generation_inline_vais_sample, grounded_generation_google_search_sample, and grounded_generation_streaming_sample functions.
- Associated Test Cases: Corresponding test functions, test_grounded_generation_inline_vais_sample and test_grounded_generation_google_search_sample, have been re-added to standalone_apis_sample_test.py to ensure coverage of the re-introduced samples.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change, re-introducing three grounded generation samples. The code is mostly fine, but I've found a critical bug in grounded_generation_streaming_sample that could lead to an UnboundLocalError, along with an incorrect type hint and a misleading comment. I've provided a suggestion to fix the bug. In the test file, there's some duplicated code for fetching the project number which could be refactored into a pytest fixture for better maintainability. Finally, a test case for the streaming sample is missing and should be added to ensure its correctness.
| from google.cloud import discoveryengine_v1 as discoveryengine | ||
|
|
||
| # TODO(developer): Uncomment these variables before running the sample. | ||
| # project_id = "YOUR_PROJECT_ID" |
There was a problem hiding this comment.
This TODO comment uses project_id, but the function parameter is project_number. For consistency with the function signature and other samples in this file, it should be project_number.
| # project_id = "YOUR_PROJECT_ID" | |
| # project_number = "YOUR_PROJECT_NUMBER" |
Reverts #13244
Fixes b/415349583