Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add get_client function #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add get_client function #1392

wants to merge 3 commits into from

Conversation

campionfellin
Copy link
Contributor

This pertains to issue #1352

It looks like list_resources.py did not have a get_client function, so I added it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2018
@theacodes
Copy link
Contributor

Thanks, @campionfellin, but we actually construct the client here in these samples, so this function isn't necessary.

@theacodes theacodes closed this Mar 12, 2018
@campionfellin
Copy link
Contributor Author

With regards to #1352 how would you suggest we fix

python-docs-samples/monitoring/api/v3/api-client/custom_metric.py

Line 176 in b56ac42

client = list_resources.get_client()
?

Would it be best to just import googleapiclient.discovery and instantiate an instance there?

@theacodes
Copy link
Contributor

theacodes commented Mar 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@campionfellin @theacodes @googlebot