modify middleware settings and url paths for django 2.0 #1503

hirokts · 2018-05-26T10:15:49Z

Please check the django 2.0 middleware settings of the official document.

(pip requirements.txt: Django==2.0.3)

https://docs.djangoproject.com/en/2.0/topics/http/middleware/

googlebot · 2018-05-26T10:15:51Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-05-27T02:38:23Z

CLAs look good, thanks!

dat-boris

The tutorial at https://cloud.google.com/python/django/kubernetes-engine is currently broken. This PR fixes the issue.

For example, the wrong middleware causes an error when accessing Django admin console:

AttributeError: 'WSGIRequest' object has no attribute 'user'

dat-boris · 2018-06-16T22:43:15Z

container_engine/django_tutorial/Dockerfile

@@ -21,11 +21,11 @@ FROM gcr.io/google_appengine/python

 # Create a virtualenv for the application dependencies.
 # # If you want to use Python 3, add the -p python3.4 flag.
-RUN virtualenv /env
+RUN virtualenv -p python3.4 /env


I bumped this to 3.6 and confirmed it works 👌

Thanks. I changed the version.

andrewsg · 2018-06-18T23:44:05Z

container_engine/django_tutorial/Dockerfile

@@ -21,11 +21,11 @@ FROM gcr.io/google_appengine/python

 # Create a virtualenv for the application dependencies.
 # # If you want to use Python 3, add the -p python3.4 flag.


We should change this comment, since python36 is preselected.

Thanks, I changed it.

andrewsg · 2018-06-19T17:24:28Z

Do the docs specify that python 3.6 specifically is used for this sample code? Is there a way we can write it to be a little more version-agnostic, for instance using -p python3 instead of 3.6?

hirokts · 2018-06-20T01:35:06Z

I confirmed it's ok to do so.
The reason of this PR is "middleware settings needs to be changed due to differences in version of django", I prefer declarative version specification. Although, assuming automatically updating the version of django (in pip requirements text) or python (in docker image), it's better to use "-p python3" or "python3 -m venv".

andrewsg · 2018-06-20T18:11:09Z

We do often update versions of dependencies such as Django as part of our maintenance (via bots). Given that, should we change it to -p python3 or do you think it should stay as it is?

morenoh149 · 2018-06-20T20:54:58Z

I fixed these issues myself. I also had to make the changes described here https://gist.github.com/morenoh149/39be1ace1f99b9571fd2b6b96098075d I could submit these as a separate PR but may make logical sense to include in this PR

googlebot · 2018-06-21T00:42:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-06-21T00:54:56Z

CLAs look good, thanks!

hirokts · 2018-06-21T01:31:30Z

Thanks.
Thinking about the situation, I changed python version specification.

I think it's better to change url path settings for django 2.
https://docs.djangoproject.com/en/2.0/ref/urls/
I changed to use django.urls .

morenoh149 · 2018-06-21T19:08:44Z

lgtm

hirokts · 2018-07-05T04:34:53Z

@andrewsg , could you check this PR?　Editing my comment may have been wrong if you did not notice the PR changing.

andrewsg · 2018-07-13T23:45:24Z

lgtm. Thanks!

modify middleware settings

66a4674

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 26, 2018

Modify Python version to adjust with Django version

45eff95

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 27, 2018

SurferJeffAtGoogle assigned andrewsg Jun 12, 2018

dat-boris reviewed Jun 16, 2018

View reviewed changes

use python3.6

49e5756

andrewsg approved these changes Jun 18, 2018

View reviewed changes

andrewsg requested changes Jun 18, 2018

View reviewed changes

hirokts added 2 commits June 19, 2018 22:22

modify the comment of virtualenv

bb8dbac

modify the comment of virtualenv

2d16591

andrewsg approved these changes Jun 19, 2018

View reviewed changes

This was referenced Jun 20, 2018

Small Django 2.0.3 Compatibility Tweaks #1525

Closed

Make Django 2.0 docker image build #1533

Closed

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 21, 2018

modify python version for virtualenv

5bc58e2

hirokts force-pushed the master branch from 291c9ae to 5bc58e2 Compare June 21, 2018 00:54

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 21, 2018

hirokts added 3 commits June 21, 2018 20:53

modify url path

9405401

Merge branch 'master' of https://github.com/hirokts/python-docs-samples

ddc5224

modify importing of mysite/urls.py

cf3c6c6

hirokts changed the title ~~modify middleware settings~~ modify middleware settings and url paths for django 2.0 Jun 21, 2018

andrewsg merged commit 47a39cc into GoogleCloudPlatform:master Jul 13, 2018

		@@ -21,11 +21,11 @@ FROM gcr.io/google_appengine/python

		# Create a virtualenv for the application dependencies.
		# # If you want to use Python 3, add the -p python3.4 flag.

modify middleware settings and url paths for django 2.0 #1503

modify middleware settings and url paths for django 2.0 #1503

Uh oh!

Conversation

hirokts commented May 26, 2018

Uh oh!

googlebot commented May 26, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented May 27, 2018

Uh oh!

dat-boris left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dat-boris Jun 16, 2018

Choose a reason for hiding this comment

Uh oh!

hirokts Jun 18, 2018

Choose a reason for hiding this comment

Uh oh!

andrewsg Jun 18, 2018

Choose a reason for hiding this comment

Uh oh!

hirokts Jun 19, 2018

Choose a reason for hiding this comment

Uh oh!

andrewsg commented Jun 19, 2018

Uh oh!

hirokts commented Jun 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewsg commented Jun 20, 2018

Uh oh!

morenoh149 commented Jun 20, 2018

Uh oh!

googlebot commented Jun 21, 2018

Uh oh!

googlebot commented Jun 21, 2018

Uh oh!

hirokts commented Jun 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morenoh149 commented Jun 21, 2018

Uh oh!

hirokts commented Jul 5, 2018

Uh oh!

andrewsg commented Jul 13, 2018

Uh oh!

Uh oh!

dat-boris left a comment •

edited

Loading

hirokts commented Jun 20, 2018 •

edited

Loading

hirokts commented Jun 21, 2018 •

edited

Loading