Still TODO:

• Set up CLOUD_KMS_KEY environment variable for CI.
• Add test for bucket default KMS key function.
• Add region tags.

@andrewsg @theacodes can you PTAL whenever you get a chance? wanted to get this up quick for review.

Should I make the CLOUD_KMS_KEY env var optional? Probably yes?

That'd be something like moving it into the test body and catching KeyError for py36 and checking if empty for py27?

It looks like our Travis build is failing because of the CLOUD_KMS_KEY thing. Let's either revisit the question of whether to make it optional, or else add it to the env vars on our test environment.

Can we add it to env vars?

Is there a way I can help here?

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Added CLA:yes, I'm okay with my contributions being added to repo.

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Thanks!

Two items pending and will send a follow-up PR for:

• Add test for bucket default KMS key function.
• Add region tags.