Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add CHC API alpha datasets and FHIR samples and tests. #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 30, 2018
Merged

Add CHC API alpha datasets and FHIR samples and tests. #1783

merged 12 commits into from
Oct 30, 2018

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Oct 22, 2018

No description provided.

@noerog noerog changed the title Add CHC API datasets samples and tests. Add CHC API alpha datasets samples and tests. Oct 22, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2018
@michaelawyu michaelawyu self-requested a review October 25, 2018 17:56
./fhir_resources.py:330:80: E501 line too long (91 > 79 characters)
    resource_path = '{}/datasets/{}/fhirStores/{}/resources/Patient/{}/$everything'.format(
./fhir_resources_test.py:22:1: E402 module level import not at top of file
import datasets
^
./fhir_resources_test.py:23:1: E402 module level import not at top of file
import fhir_stores
^
./fhir_resources_test.py:24:1: E402 module level import not at top of file
import fhir_resources
^
./fhir_stores.py:85:80: E501 line too long (82 > 79 characters)
    fhir_store_name = 'projects/{}/locations/{}/datasets/{}/fhirStores/{}'.format(
                                                                               ^
./fhir_stores.py:111:80: E501 line too long (82 > 79 characters)
    fhir_store_name = 'projects/{}/locations/{}/datasets/{}/fhirStores/{}'.format(
                                                                               ^
./fhir_stores.py:340:5: E303 too many blank lines (2)
    command = parser.add_subparsers(dest='command')
    ^
./fhir_stores.py:347:80: E501 line too long (81 > 79 characters)
    command.add_parser('export-fhir-resource', help=import_fhir_resource.__doc__)
                                                                               ^
./fhir_stores.py:348:80: E501 line too long (81 > 79 characters)
    command.add_parser('import-fhir-resource', help=export_fhir_resource.__doc__)
                                                                               ^
./fhir_stores.py:349:1: W293 blank line contains whitespace
./fhir_stores_test.py:22:1: E402 module level import not at top of file
import datasets
^
./fhir_stores_test.py:23:1: E402 module level import not at top of file
import fhir_stores
@noerog noerog changed the title Add CHC API alpha datasets samples and tests. Add CHC API alpha datasets and FHIR samples and tests. Oct 29, 2018
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@michaelawyu
Copy link
Contributor

Will merge after the test passes.

@michaelawyu michaelawyu merged commit bfd5d07 into GoogleCloudPlatform:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants