Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Updates region to include tasks: datastore_batch_upsert #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2019
Merged

fix: Updates region to include tasks: datastore_batch_upsert #2212

merged 3 commits into from
Jun 13, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 11, 2019

We need to include task1 and task2 in this sample for it to make sense.
b/111318350

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
@grant grant requested review from averikitsch and ace-n June 11, 2019 21:46
@grant grant added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 12, 2019
@grant grant self-assigned this Jun 13, 2019
@grant grant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2019
@grant
Copy link
Contributor Author

grant commented Jun 13, 2019

How do I force Kokoro to run?
This change shouldn't break the tests.

@ace-n
Copy link

ace-n commented Jun 13, 2019

cc @engelke

@grant
Copy link
Contributor Author

grant commented Jun 13, 2019

Trying to push a file to get the tests to run

engelke
engelke reviewed Jun 13, 2019
View reviewed changes
vision/cloud-client/document_text/env/.Python Outdated
@@ -0,0 +1 @@
/System/Library/Frameworks/Python.framework/Versions/2.7/Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include these env files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file is outdated and creds are revoked.

@grant grant merged commit fb2c633 into master Jun 13, 2019
@grant grant deleted the grant-datastore_batch_upsert branch June 13, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke left review comments

@ace-n ace-n ace-n approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch

Assignees

@grant grant

Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grant @ace-n @engelke @googlebot