Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update functions/sql example to use more clear connection logic. #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2019
Merged

Update functions/sql example to use more clear connection logic. #2486

merged 3 commits into from
Oct 18, 2019

Conversation

kurtisvg
Copy link
Contributor

Fixes #2127

@kurtisvg kurtisvg requested a review from ace-n October 18, 2019 15:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2019
@kurtisvg kurtisvg removed the request for review from ace-n October 18, 2019 15:42
dmahugh
dmahugh approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@dmahugh dmahugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtisvg kurtisvg merged commit c311bc3 into master Oct 18, 2019
@kurtisvg kurtisvg deleted the kurtisvg-patch-1 branch October 18, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmahugh dmahugh dmahugh approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in the Cloud Function MySQL example
3 participants
@kurtisvg @dmahugh @googlebot