Cloud Healthcare API beta FHIR updates #2639
Conversation
|
Can this be merged if all tests except 3.7 are passing? |
|
@noerog Is there a reason you don't want / need Python 3.7 support? |
|
Not really, but if it passes on our main/required tests I'd rather submit the PR and fix 3.7 later because the test failure makes no sense to me right now. |
|
I can take a look to see if there's something you can do to fix 3.7. I'd prefer to avoid committing something that breaks on the latest Python. |
|
Looks like a race condition? I'll see if re-running gets 'em green. |
|
It appears that in Python 3.x there's a problem, I'll investigate further. |
|
@crwilcox Any ideas on why these tests are passing locally but failing on CI? |
|
Just an fyi: now 3.7, which was failing a week ago, is passing, but 3.5 is failing, even though no code has changed. |
|
taking a look |
|
I suspect the conditional update/patch errors were caused by there being duplicate FHIR resources. According to the FHIR spec for conditional update and patch, if there are multiple versions of a resource that are detected, a 412 error is returned: https://www.hl7.org/fhir/http.html#cond-update / https://www.hl7.org/fhir/http.html#patch |
|
Healthcare tests are all passing but it seems that /automl/ tests are failing which causes the whole suite to fail. |
| assert "Got Patient resource" in out | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason='flaky test sometimes returns 403 errors, need to investigate') |
There was a problem hiding this comment.
I'm cool with a skip as long as an issue gets opened up in the repo referencing this
|
|
||
| @pytest.mark.skip(reason='flaky test sometimes returns 403 errors, need to investigate') | ||
| def test_conditional_patch_resource(test_dataset, test_fhir_store, test_patient, capsys): | ||
| # The conditional method tests use an Observation, so we have to create an |
There was a problem hiding this comment.
these comments are informative - thank you!
| fhir_store_id, | ||
| ) | ||
|
|
||
| # In accordance with the FHIR spec, if conditional patch or conditional update |
There was a problem hiding this comment.
👏 again with the helpful comments 🎉
| assert "Conditionally patched" in out | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason='flaky test sometimes returns 412 errors, need to investigate') |
There was a problem hiding this comment.
same as above - want to see an issue opened for this investigation (ideally with you assigned to this and the other :) )
Split create_resource into 3 components and update region tags/tests:
create_patient
create_encounter
create_observation
In tests, create a patient fixture to use in different test methods.
Update README.
Add file and tests for executeBundle.
Add conditions for each conditional method (conditionalUpdate, conditionalPatch, conditionalDelete)