Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: changes fields printed in list glossary sample; some minor fixes #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

fix: changes fields printed in list glossary sample; some minor fixes #2746

merged 1 commit into from
Jan 23, 2020

Conversation

telpirion
Copy link
Contributor

Adds a comment; removes extraneous field access in Translation glossary samples.

Affected region tags / code snippets:

  • translate_v3_create_glossary
  • translate_v3_list_glossary

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
@busunkim96 busunkim96 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2020
@telpirion
Copy link
Contributor Author

Thank you! @busunkim96 would you please merge this pull request? I don't have write access.

@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2020
@busunkim96
Copy link
Contributor

@telpirion Definitely! Will merge once CI is green. Something strange is happening with Kokoro right now.

@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2020
@busunkim96
Copy link
Contributor

Oh, I see. These aren't being merged into master, so the checks aren't running. 😅 Merging now.

@busunkim96 busunkim96 merged commit fef998b into GoogleCloudPlatform:tmp-generated-samples Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@telpirion @busunkim96 @googlebot @kokoro-team