Thanks to visit codestin.com
Credit goes to github.com

Skip to content

endpoints: Modify gRPC bookstore to support gRPC on Cloud Run #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmahugh merged 6 commits into from
Feb 6, 2020
Merged

endpoints: Modify gRPC bookstore to support gRPC on Cloud Run #2764

dmahugh merged 6 commits into from
Feb 6, 2020

Conversation

@nareddyt
Copy link
Contributor

@nareddyt nareddyt commented Feb 3, 2020

  • Allow client to make TLS calls
  • Server determines port from env var

New docker image already released: gcr.io/endpointsv2/python-grpc-bookstore-server:2

@nareddyt
endpoints: Modify gRPC bookstore to support gRPC on Cloud Run
4fb4996 
- Allow client to make TLS calls
- Server determines port from env var

Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt
Modify dockerfile, move roots.pem
a847343 
Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt nareddyt requested review from a team and daniel-sanche as code owners February 3, 2020 20:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@nareddyt nareddyt requested a review from leahecole February 4, 2020 19:15
@nareddyt nareddyt requested a review from dmahugh February 5, 2020 00:53
dmahugh
dmahugh approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@dmahugh dmahugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daniel-sanche
daniel-sanche approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmahugh dmahugh merged commit 830d363 into GoogleCloudPlatform:master Feb 6, 2020
@nareddyt nareddyt deleted the endpoints-grpc-cloud-run branch February 6, 2020 02:28
@tmatsuo tmatsuo mentioned this pull request Jun 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@leahecole leahecole Awaiting requested review from leahecole

+2 more reviewers

@dmahugh dmahugh dmahugh approved these changes

@qiwzhang qiwzhang qiwzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmahugh dmahugh

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nareddyt @dmahugh @daniel-sanche @qiwzhang @googlebot @leahecole