Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add GAE billing limit sample #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Add GAE billing limit sample #2771

merged 4 commits into from
Feb 5, 2020

Conversation

ace-n
Copy link

@ace-n ace-n commented Feb 5, 2020

Why no tests?
It's been tested manually, and we're trying to merge ASAP. Will fast-follow with tests once this is merged.

@ace-n ace-n requested a review from andrewsg February 5, 2020 00:00
@ace-n ace-n requested review from grant and a team as code owners February 5, 2020 00:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue on this repo and assign it to yourself to adding tests.

@kurtisvg
Copy link
Contributor

kurtisvg commented Feb 5, 2020

Overriding - functions is a 3.7+ environment only

@kurtisvg kurtisvg merged commit 5c0ac23 into master Feb 5, 2020
@kurtisvg kurtisvg deleted the gae-billing branch February 5, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants