Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix incorrect data submission #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Conversation

dhercher
Copy link
Contributor

The configuration to send composer needs to be inside the data block rather than the JSON body itself

The configuration to send composer needs to be inside the data block rather than the JSON body itself
@dhercher dhercher requested review from grant and a team as code owners February 11, 2020 03:14
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 11, 2020
@dhercher
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 11, 2020
@grant grant requested a review from leahecole February 11, 2020 03:55
@grant
Copy link
Contributor

grant commented Feb 11, 2020

Looks fine but the author @leahecole should approve.

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@leahecole
Copy link
Collaborator

@dhercher are you running this from Google cloud functions? I just ran it this morning following this tutorial (which the code was written for) and it worked fine - could you tell me more about what you're trying to do and the desired outcome?

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@leahecole leahecole merged commit ec2cb4b into GoogleCloudPlatform:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants