Migrate Python 2.7 storage sample to Python 3 #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Python 3.7 version)
busunkim96
reviewed
Feb 25, 2020
|
@engelke is there a requirement to make this work for Python 2.7? I would prefer we don't grow our Python 2.7 samples further. |
|
@crwilcox This is specifically for the purpose of a 2.7 to 3.7 migration tutorial, so 2.7 support is required. |
|
The idea is that users will modify their code to follow this example while
staying on Python 2.7. Then, when all the old APIs have been replaced,
migrate to 3.7.
…On Fri, Mar 6, 2020 at 12:00 PM Andrew Gorcester ***@***.***> wrote:
@crwilcox <https://github.com/crwilcox> This is specifically for the
purpose of a 2.7 to 3.7 migration tutorial, so 2.7 support is required.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2989?email_source=notifications&email_token=AAAT6NZBB2HHPU63CM5YVFTRGFI5NA5CNFSM4K3ULTE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOCVTMI#issuecomment-595941809>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT6NZW5XNJTXNJCNEWIQTRGFI5NANCNFSM4K3ULTEQ>
.
--
Charles Engelke
GCP AppDev DPE
|
andrewsg
approved these changes
Mar 6, 2020
|
@engelke Can you fix the lint error? I think you also need to rebase to master. |
|
@engelke I haven't seen any activities for a while. I'll close this PR on Friday. |
|
Trying to delete old branch. |
|
"merging" these zero changes just so I can delete the stale branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a sample for Cloud Storage that runs on App Engine standard for Python 2.7 and for Python 3.7.