fix: adjust bigquery/cloud-client to allow concurrent testing #3136
Conversation
gguuss
left a comment
There was a problem hiding this comment.
LGTM when the tests pass. Optional change suggestion - I've been asked to avoid reusing resources in testing and instead use unique resources per-test (e.g. create a database with UUID in the name).
In this case, I'm generally more okay with datasets being longlived because there's a higher expectation of persistence by users, and the dataset itself has no cost (resources inside are a different story). |
…samples into fix-2580-natality
| if entry.entity_type != 'view'] | ||
| client.update_dataset(ds, ['access_entries']) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
nit: can we add a print statement at minimum here or catch a specific exception?
|
Abandoning this one for a different approach. |
Natality test was overly stateful. Change to optimistic dataset creation and elide truncation mode to allow for concurrent overwriting.
Fixes: #2850