[bigtable] Cloud function example #3486
Conversation
functions/bigtable/main_test.py
Outdated
| bigtable.Client = MagicMock() | ||
|
|
||
|
|
||
| class TestingRow: |
There was a problem hiding this comment.
You're using your own class. How are you confident on whether bigtable_read_data() really works with the actual Bigtable service?
Is it difficult to write a test with the real service?
There was a problem hiding this comment.
I'm just following the examples of all the other tests that we have. I couldn't figure how to create objects using the existing classes.
There was a problem hiding this comment.
Can you write a test that acctually access BigTable?
Adding more line breaks
functions/bigtable/main_test.py
Outdated
| bigtable.Client = MagicMock() | ||
|
|
||
|
|
||
| class TestingRow: |
There was a problem hiding this comment.
Can you write a test that acctually access BigTable?
|
@tmatsuo tests are fixed and green :) |
|
@billyjacobson I still see the test with a mock. |
|
@tmatsuo oops!! I forgot to push, sorry about that |
functions/bigtable/main_test.py
Outdated
| import datetime | ||
| import os | ||
| import uuid | ||
| import pytest |
There was a problem hiding this comment.
pytest is a 3rd party library. Can you do the following
import datetime
import os
import uuid
from google.cloud import bigtable
from requests import Request
import pytest
import main?
There was a problem hiding this comment.
I still see pytest is in standard library block.
There was a problem hiding this comment.
Sorry, I fixed this, but was getting this when pushing which I guess prevented it from going in
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing...
|
|
||
| response = main.bigtable_read_data(request) | ||
|
|
||
| assert """Rowkey: phone#4c410523#20190501, os_build: PQ2A.190405.003 |
There was a problem hiding this comment.
Nit: I'm not sure if you really need these multiple rows? I think the test is still valid with fewer rows (maybe just 1 row). WDYT?
There was a problem hiding this comment.
eh, I'm fine with leaving it. Consistent with other tests
There was a problem hiding this comment.
I'm not sure I agree. If possible, I want to have minimum amount of test data.
|
@tmatsuo let me know if you think this is ready, thanks |
|
@tmatsuo the Lint is failing, but when I try to run the linter locally it says the noxfile isn't found |
|
@billyjacobson Now you have to temporarily copy the The code looks good now and I hope rebasing will solve the linter. |
|
@billyjacobson Merged. Thanks for your patience. |
No description provided.