Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the call to validate_iap (#4260) #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix the call to validate_iap (#4260) #4466

merged 1 commit into from
Aug 10, 2020

Conversation

mohangk
Copy link

@mohangk mohangk commented Aug 10, 2020

Description

Fixes #4260

The method signature for validate_iap changed with 41c173 but the
call to validate_iap from example_gce_backend.py was not changed

Fix the call to validate_iap (GoogleCloudPlatform#4260)
03b9dfb 
The method signature for validate_iap changed with 41c173 but the
call to validate_iap from example_gce_backend.py was not changed
@mohangk mohangk requested a review from a team as a code owner August 10, 2020 06:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@mohangk mohangk mentioned this pull request Aug 10, 2020
Closed
@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 10, 2020
@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 10, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 10, 2020
engelke
engelke approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit aa9bd5e into GoogleCloudPlatform:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue with "python-docs-samples/iap/example_startup_script.sh"
4 participants
@mohangk @engelke @kurtisvg @kokoro-team