feat(appengine): Pub/Sub sample for both Python 2.7 and 3 #4489

engelke · 2020-08-12T20:12:39Z

Description

New sample per migration roadmap.

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.6 (see Test Environment Setup)
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
Please merge this PR for me once it is approved.
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample

Make sample work in both Python 2.7 and 3 environments

bf5ddb5

engelke requested a review from a team as a code owner August 12, 2020 20:12

blunderbuss-gcf bot assigned busunkim96 Aug 12, 2020

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2020

Lint fix

402e45a

busunkim96 approved these changes Aug 12, 2020

View reviewed changes

engelke requested a review from ace-n August 12, 2020 20:32

Merge branch 'master' into pubsub-migration

dcc36d9

product-auto-label bot added the samples Issues that are directly related to samples. label Aug 21, 2020

tmatsuo approved these changes Sep 11, 2020

View reviewed changes

Merge branch 'master' into pubsub-migration

a1424a1

tmatsuo changed the title ~~Feat: sample for both Python 2.7 and 3~~ feat(appengine): Pub/Sub sample for both Python 2.7 and 3 Sep 11, 2020

tmatsuo merged commit a24558f into master Sep 11, 2020

tmatsuo deleted the pubsub-migration branch September 11, 2020 18:23

wescpy mentioned this pull request Jul 26, 2022

requirements.txt doesn't support Python 2 #8205

Closed