Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: addresses broken Vision test in Translation hybrid tutorial #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 9, 2020
Merged

fix: addresses broken Vision test in Translation hybrid tutorial #4548

merged 6 commits into from
Sep 9, 2020

Conversation

telpirion
Copy link
Contributor

Fixes #4529

This PR does the following:

  • changes the assert in one test to check for existence of text (rather than exact string)
  • removes unneeded tests
  • removes unneeded resources

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2020
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 26, 2020
tmatsuo
tmatsuo approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you fix lint?

@telpirion telpirion marked this pull request as ready for review September 8, 2020 22:27
@telpirion telpirion requested review from sirtorry and a team as code owners September 8, 2020 22:27
@busunkim96
Copy link
Contributor

👋 @ericschmidtatwork Could this be opened in https://github.com/googleapis/python-translate/tree/master/samples/snippets/hybrid_glossaries instead? I've been holding off on deleting the translate/ directory in python-docs-samples because the Automl directory still needs to be sorted out. The translate samples are already referencing the python-translate repository (example: https://cloud.google.com/translate/docs/advanced/batch-translation)

@telpirion telpirion requested a review from leahecole September 9, 2020 16:04
@telpirion
Copy link
Contributor Author

@busunkim96 I did not realize that the translation samples had migrated already. Yes, I can make this change over in googleapis/python-translate.

@telpirion
Copy link
Contributor Author

@busunkim96 I did not realize that the translation samples had migrated already. Yes, I can make this change over in googleapis/python-translate.

Rather, let's make this change in both places so that we can close #4529 .

@telpirion telpirion mentioned this pull request Sep 9, 2020
Merged
@telpirion telpirion merged commit 80c1e2f into master Sep 9, 2020
@telpirion telpirion deleted the hybrid_tutorial_fix branch September 9, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@leahecole leahecole Awaiting requested review from leahecole

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hybrid_glossaries.hybrid_tutorial_test: test_vision_standard_format failed
5 participants
@telpirion @busunkim96 @tmatsuo @vinnysenthil @kokoro-team